feat(jail): safe Oxy testbed lifecycle candidate #24

Merged

clawdie merged 17 commits from clawdie/merge/oxy-testbed-corrected into main 2026-10-29 19:32:01 +01:00 AGit

Conversation 0 Commits 17 Files changed 6 +2073 -21

clawdie commented 2026-10-29 13:06:17 +01:00

Owner

Copy link

Safe ISO merge candidate for the Oxy testbed feature plus all safety corrections.

This branch contains the reviewed feature pin 537bf39 and the follow-up corrections through d6060b8:

• create-only provision/clone with destination preflight for directories, dangling symlinks, parent datasets, and exact root datasets;
• no automatic untagged-jail destroy or synthesized lifecycle tags;
• tri-state jls handling (running/stopped/unknown) with fail-closed cleanup;
• normalized IP and gateway verification against readable jail.conf and explicit expectations;
• only jail-alias accepted; jail-vnet/bhyve rejected before mutation;
• regression coverage for active/stopped re-clone, destination preflight, protected provision, untagged/failed-jls destroy, IP/gateway mismatch, and unsupported kinds;
• docs already in stacked PRs.

Do not merge PR #22 alone. This is the single safe ISO merge candidate targeting main.

Checks on the candidate:

sh scripts/tests/jail-run-test.sh          rc=0, 11 checks
sh scripts/tests/test-jail-lifecycle.sh   rc=0, 11 checks
sh scripts/ci-checks.sh                   rc=0

No real jail or dataset mutations were performed during verification.

Safe ISO merge candidate for the Oxy testbed feature plus all safety corrections. This branch contains the reviewed feature pin `537bf39` and the follow-up corrections through `d6060b8`: - create-only provision/clone with destination preflight for directories, dangling symlinks, parent datasets, and exact root datasets; - no automatic untagged-jail destroy or synthesized lifecycle tags; - tri-state `jls` handling (running/stopped/unknown) with fail-closed cleanup; - normalized IP and gateway verification against readable jail.conf and explicit expectations; - only `jail-alias` accepted; `jail-vnet`/`bhyve` rejected before mutation; - regression coverage for active/stopped re-clone, destination preflight, protected provision, untagged/failed-jls destroy, IP/gateway mismatch, and unsupported kinds; - docs already in stacked PRs. Do not merge PR #22 alone. This is the single safe ISO merge candidate targeting `main`. Checks on the candidate: ```text sh scripts/tests/jail-run-test.sh rc=0, 11 checks sh scripts/tests/test-jail-lifecycle.sh rc=0, 11 checks sh scripts/ci-checks.sh rc=0 ``` No real jail or dataset mutations were performed during verification.

clawdie added 13 commits 2026-10-29 13:06:17 +01:00

feat(jail): add disposable testbed provisioner and lifecycle destroy guard ... b9466d1373

Add scripts/jail-testbed.sh (provision|verify|destroy|status) for a metadata-disposable Bastille jail. It writes a local clawdie:lifecycle tag, root-base lineage stamp, 0755 probe-readable directories, and stages the host oxigraph binary into the jail. Provisioning is idempotent and refuses protected names such as cms.

Extend jail-run.sh destroy authorization to accept a non-name-disposable jail when its exact root dataset carries local clawdie:lifecycle=temp, while retaining --allow-production as the explicit override. Add hermetic coverage for the provisioner and the new destroy path, and wire both tests into ci-checks.sh.

fix(jail): enforce local ZFS lifecycle source on destroy and support Linux stat in testbed fcfa1593b6

feat(jail): add start action, prevent daemon pipe-hang on create/start, and enforce 6-arg zfs get in test shims 553c766e5c

test(jail): keep protected-name fixture inside test tempdir c02401c277

feat(jail): rename testbed helper to jail-lifecycle.sh with scoped mount cleanup and doas escalation af693908e6

fix(jail): use foreground timeout so jail daemons cannot block create/start a8ba6e08eb

docs(jail): install companion jail-run with lifecycle helper 2ec5737ab1

feat(jail-lifecycle): add ZFS block-sharing clone action and snapshot cleanup a2f4767b06

fix(jail-lifecycle): derive clone parent_template from ZFS origin in verify and log initial/active used 24275369a2

feat(jail-lifecycle): write and verify 9-property clawdie:* ZFS metadata schema acc4ad16ca

fix(jail-lifecycle): normalize clawdie:ip by stripping bastille iface prefix 537bf39a79

fix(jail-lifecycle): make create-only and reject unsafe existing state d56f75c521

fix(jail-lifecycle): preflight all destination entries and reconcile configured IP d6060b8930

clawdie added 2 commits 2026-10-29 14:28:02 +01:00

fix(jail-lifecycle): harden standalone verify, dependent-clone destroy, and CI gates 98822c6bd4

fix(jail-lifecycle): fail closed when clone inventory query fails ec4a0c353f

clawdie added 1 commit 2026-10-29 16:58:02 +01:00

fix(jail-lifecycle): refuse unowned cleanup targets and untagged clones c2a910e417

clawdie added 1 commit 2026-10-29 19:29:55 +01:00

fix(jail-lifecycle): require confirmed stopped state before absent-root snapshot cleanup ... 5ca4c35249

- In destroy()'s absent-root branch (! dataset_exists), verify jail_state() is
  positively 'stopped' (and not 'unknown' or 'running') before invoking
  cleanup_orphan_clone_snapshots(), preventing orphan @clone-<jail> snapshots
  from being deleted before a failing jls or running target causes refusal.
- In dataset_dependent_clones(), fail closed (return 2) when zfs get clones
  returns empty stdout.
- Adapt test-jail-lifecycle.sh printf '-' literals to printf '%s\n' '-' for
  POSIX/dash portability and add regression coverage for absent-root unknown
  and running states, stopped-state orphan cleanup, empty clones output, and
  snapshot destroy failures.

clawdie merged commit 653da7f3ae into main 2026-10-29 19:32:01 +01:00

clawdie referenced this pull request from a commit 2026-10-29 19:32:02 +01:00

Merge pull request 'feat(jail): safe Oxy testbed lifecycle candidate' (#24) from clawdie/merge/oxy-testbed-corrected into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

clawdie/clawdie-iso!24

No description provided.