fix(paths): resolve the herdr socket under the host-root run dir #38

Merged

clawdie merged 2 commits from fix/socket-under-host-root into main 2026-10-05 15:17:10 +02:00

Conversation 0 Commits 2 Files changed 6 +128 -69

clawdie commented 2026-10-05 15:11:26 +02:00

Owner

Copy link

What

A socket does not belong in a config directory.

internal/paths/paths.go: CanonicalSocketPath now resolves under RunDir() —
<CLAWDIE_HOST_ROOT>/run when a host root is set, else $XDG_RUNTIME_DIR/herdr,
else /tmp/herdr-<uid> — instead of ~/.config/herdr/herdr.sock. Explicit
sessionName and the HERDR_SOCKET_PATH / HERDR_SESSION overrides are
unchanged.

Tests

• go test ./internal/paths/ → ok, incl. new TestSocketPathNotInConfigDir
  (regression guard) and TestSocketPathRuntimeDir.
• go vet ./internal/paths/ and gofmt clean; go build ./internal/... ok.
  (go build ./... links libghostty-vt.a, absent in this env — pre-existing.)

Rule: colibri docs/wiki/host-paths.md (light mode = host root; hive = colibri service).

## What A socket does not belong in a config directory. `internal/paths/paths.go`: `CanonicalSocketPath` now resolves under `RunDir()` — `<CLAWDIE_HOST_ROOT>/run` when a host root is set, else `$XDG_RUNTIME_DIR/herdr`, else `/tmp/herdr-<uid>` — instead of `~/.config/herdr/herdr.sock`. Explicit `sessionName` and the `HERDR_SOCKET_PATH` / `HERDR_SESSION` overrides are unchanged. ## Tests - `go test ./internal/paths/` → ok, incl. new `TestSocketPathNotInConfigDir` (regression guard) and `TestSocketPathRuntimeDir`. - `go vet ./internal/paths/` and `gofmt` clean; `go build ./internal/...` ok. (`go build ./...` links `libghostty-vt.a`, absent in this env — pre-existing.) Rule: colibri `docs/wiki/host-paths.md` (light mode = host root; hive = colibri service).

clawdie added 1 commit 2026-10-05 15:11:26 +02:00

fix(paths): resolve the herdr socket under the host-root run dir ... e26dda5ced

A socket does not belong in a config directory. CanonicalSocketPath now
resolves under RunDir(): <CLAWDIE_HOST_ROOT>/run when a host root is set, else
$XDG_RUNTIME_DIR/herdr, else /tmp/herdr-<uid>. Explicit sessionName and the
HERDR_SOCKET_PATH/HERDR_SESSION overrides are unchanged.

Adds TestSocketPathNotInConfigDir (regression guard) and TestSocketPathRuntimeDir.
See colibri docs/wiki/host-paths.md for the light-mode vs hive rule.

clawdie added 1 commit 2026-10-05 15:16:19 +02:00

chore: gofmt internal/wire (pre-existing drift on main) ... af6c8234d0

rect.go, wire.go and wire_test.go (from 410e816) were unformatted on main,
which red-lights the repo-wide gofmt check for every PR. Whitespace only.

clawdie merged commit ceb38ff957 into main 2026-10-05 15:17:10 +02:00

clawdie deleted branch fix/socket-under-host-root 2026-10-05 15:17:10 +02:00

clawdie referenced this pull request from a commit 2026-10-05 15:17:12 +02:00

Merge pull request 'fix(paths): resolve the herdr socket under the host-root run dir' (#38) from fix/socket-under-host-root into main

clawdie referenced this pull request 2026-10-06 09:16:29 +02:00

docs: resolve the herdr socket under the runtime dir #39

clawdie referenced this pull request from a commit 2026-10-06 10:49:23 +02:00

test(cli): isolate sockets via CLAWDIE_HOST_ROOT and paths.SocketPath

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

clawdie/bherdr!38

No description provided.